fix: error handling for gradle wrapper call #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * if something wrong gradle wrapper would just exit withuot info/error. This change addreses the need by: * Use `ProcessBuilder` to easily direct input/output/error to mvn output * Check the error code and warn via error * Don't pass empty env to the fork as otherwise JAVA_HOME is not picked up. Note - Generated Gradle builds will still fail but that is due to quarkusio#4365 - a separate concern. Fixes quarkusio#4321
aloubyansky
approved these changes
Oct 4, 2019
aloubyansky
added
the
triage/waiting-for-ci
kenfinnigan
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
This change addreses the need by:
ProcessBuilderto easily direct input/output/error to mvn outputup.
Note - Generated Gradle builds will still fail but that is due to
#4365 - a separate concern.
Fixes #4321