Fix minor wording issues in integration tests README.md #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenfinnigan
approved these changes
Oct 4, 2019
kenfinnigan
added
the
triage/waiting-for-ci
Sanne
reviewed
Oct 4, 2019
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| By default, the tests of this module are disabled. | |||
|
|
|||
| To run the tests in a standard JVM with MySQL started as a Docker container, you can run the following command: | |||
| To run the tests in a standard JVM with MariaDB started as a Docker container, you can run the following command: | |||
There was a problem hiding this comment.
This module is called reactive-mysql-client: why is it using MariaDB for testing?
There was a problem hiding this comment.
Because I suppose it supports both? I haven't changed it, just made the README state what the code does. @tsegismont wrote this IIRC.
|
Yeah, it's confusing that the module name is one thing and the README talks about something else. |
|
Well, the README says what we're doing, which is less confusing than before. You can change the ITs to use MySQL but my understanding was that we were favoring MariaDB over MySQL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor but posted my review too late.