Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding and removing extensions from Dev UI #43840

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Oct 12, 2024

This PR add the "quarkus add" and "quarkus remove" to Dev UI. It allows you to browse (and search) for installable extensions in Dev UI and install them from Dev UI. It also adds a remove button on the details screen on the extension if it can be uninstalled.

extension_management_dev_ui

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform area/vertx labels Oct 12, 2024
Copy link

github-actions bot commented Oct 12, 2024

🎊 PR Preview 123ea8e has been successfully built and deployed to https://quarkus-pr-main-43840-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@phillip-kruger phillip-kruger force-pushed the dev-ui-add-ext branch 2 times, most recently from 7629b23 to 1a7e628 Compare October 13, 2024 22:46

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@cescoffier
Copy link
Member

Looks like it breaks a few things :-)

@phillip-kruger
Copy link
Member Author

phillip-kruger commented Oct 14, 2024

@cescoffier yes I don't know why. The tests that breaks in CI runs fine on localhost. Maybe @maxandersen can comment ?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a micro comment but, more importantly, before merging, I think we need to make sure this doesn't slow down the startup too much:

  • Creating an ObjectMapper can be sometimes slow. Now it might just be the first ObjectMapper creation that is slow but we need to check for it.
  • The second thing that worries me is that the test failures seem to point out the fact that you're trying to update the registry even when not actually doing anything related to your new feature. Updating the registry is slow so I definitely don't want us to pay the price of updating it every day if you don't need it - and there's a good chance you won't add a dependency or create a new app every day. To test that, you will have to drop the local registry artifact and see how it performs at startup.

Not saying these are actual issues or issues we cannot solve but we need to make sure this feature is not introducing a regression in daily life developer experience.

This review can be dropped once everything is sorted out but I just want to make sure nobody merges before we have checked the situation.

extensions/vertx-http/deployment/pom.xml Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

@phillip-kruger
Copy link
Member Author

The test broke because of Remove Dev. This is now fixed, let's see what CI does

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
Copy link

quarkus-bot bot commented Oct 29, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 94b3209.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

This comment has been minimized.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I just wonder why the path tests have been moved around.

Copy link

quarkus-bot bot commented Oct 29, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 94b3209.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cescoffier
Copy link
Member

LGTM - I just wonder why the path tests have been moved around.

@phillip-kruger gave me the answer. The tests (made by me a few years ago) were not located in their proper location - it was working _magically). It makes a lot more sense now.

@cescoffier cescoffier merged commit d400eb7 into quarkusio:main Oct 30, 2024
54 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 30, 2024
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 30, 2024
@cescoffier
Copy link
Member

Remove the backport label - this is a feature, not a bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/health area/openapi area/platform Issues related to definition and interaction with Quarkus Platform area/smallrye area/vertx triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants