-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding and removing extensions from Dev UI #43840
Conversation
2beade2
to
3775def
Compare
🎊 PR Preview 123ea8e has been successfully built and deployed to https://quarkus-pr-main-43840-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7629b23
to
1a7e628
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks like it breaks a few things :-) |
@cescoffier yes I don't know why. The tests that breaks in CI runs fine on localhost. Maybe @maxandersen can comment ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a micro comment but, more importantly, before merging, I think we need to make sure this doesn't slow down the startup too much:
- Creating an
ObjectMapper
can be sometimes slow. Now it might just be the firstObjectMapper
creation that is slow but we need to check for it. - The second thing that worries me is that the test failures seem to point out the fact that you're trying to update the registry even when not actually doing anything related to your new feature. Updating the registry is slow so I definitely don't want us to pay the price of updating it every day if you don't need it - and there's a good chance you won't add a dependency or create a new app every day. To test that, you will have to drop the local registry artifact and see how it performs at startup.
Not saying these are actual issues or issues we cannot solve but we need to make sure this feature is not introducing a regression in daily life developer experience.
This review can be dropped once everything is sorted out but I just want to make sure nobody merges before we have checked the situation.
1a7e628
to
f141d01
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0276851
to
2f58b72
Compare
2f58b72
to
7be6fb0
Compare
The test broke because of Remove Dev. This is now fixed, let's see what CI does |
7be6fb0
to
2cb7138
Compare
extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-extension.js
Outdated
Show resolved
Hide resolved
extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-extensions.js
Outdated
Show resolved
Hide resolved
extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-extensions.js
Outdated
Show resolved
Hide resolved
...common/src/main/java/io/quarkus/devtools/commands/handlers/ListCategoriesCommandHandler.java
Outdated
Show resolved
Hide resolved
644c74e
to
40fad0b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
40fad0b
to
df5e3ae
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
df5e3ae
to
1fd57d6
Compare
This comment has been minimized.
This comment has been minimized.
1fd57d6
to
2ed1745
Compare
2ed1745
to
2dc18b3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2dc18b3
to
ddd88ef
Compare
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
ddd88ef
to
94b3209
Compare
Status for workflow
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I just wonder why the path tests have been moved around.
...oyment/src/test/java/io/quarkus/smallrye/health/test/PathMatchingHttpSecurityPolicyTest.java
Show resolved
Hide resolved
...loyment/src/test/java/io/quarkus/vertx/http/security/PathMatchingHttpSecurityPolicyTest.java
Show resolved
Hide resolved
Status for workflow
|
@phillip-kruger gave me the answer. The tests (made by me a few years ago) were not located in their proper location - it was working _magically). It makes a lot more sense now. |
Remove the backport label - this is a feature, not a bug fix. |
This PR add the "quarkus add" and "quarkus remove" to Dev UI. It allows you to browse (and search) for installable extensions in Dev UI and install them from Dev UI. It also adds a remove button on the details screen on the extension if it can be uninstalled.