ArC: document the @ObservesAsync pitfall with reactive programming #43856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have marked this PR as fixing #29191, because it looks like we're not keen on actually doing something out of spec here. If someone disagrees, please let me know and I will unmark this PR and keep the issue open. |
mkouba
approved these changes
Oct 14, 2024
|
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
gsmet
reviewed
Oct 14, 2024
| You may declare an observer method that has a return type of `CompletionStage<>` or `Uni<>`, but neither the return type nor the actual return value affect the result of `Event.fireAsync()`. | ||
| Further, if the observer declares a return type of `Uni<>`, the returned `Uni` will not be subscribed to, so it is quite possible that part of the observer logic will not even execute. | ||
|
|
||
| Therefore, it is recommended that observer methods, both synchronous and asynchronous, are always declared `void`. |
There was a problem hiding this comment.
@sheilamjones not sure who to report this to but this rule needs tweaking. AFAICS it is triggered by asynchronous.
manovotn
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29191