-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding some additional conditionals for the TLS guide #43879
Adding some additional conditionals for the TLS guide #43879
Conversation
Signed-off-by: Michal Maléř <mmaler@redhat.com>
Status for workflow
|
🙈 The PR is closed and the preview is expired. |
This will need to be backported to 3.15. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not particularly happy about this being in the upstream docs, but... yeah. If it's a product requirement that we can't achieve in other ways...
(If we go on adding these things, I'm scared it may explode horribly)
@jmartisk @cescoffier
Moreover, any activities related to tooling and scripting have been prohibited (for us, writers), so these workarounds using attributes, Please merge if there are no other objections. I am also for finding of a better solution in the future, but Quarkus dev help will be required. This is the best the docs team can do on their own. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit. LGTM
|
||
TLS Registry also provides automatic certificate reloading | ||
ifndef::no-lets-encrypt[] | ||
, integration with Let's Encrypt (ACME) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on QE feedback, I am applying some additional conditionals to reuse this content further.