Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some additional conditionals for the TLS guide #43879

Conversation

MichalMaler
Copy link
Contributor

Based on QE feedback, I am applying some additional conditionals to reuse this content further.

Signed-off-by: Michal Maléř <mmaler@redhat.com>
Copy link

quarkus-bot bot commented Oct 15, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 2ff9f1e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented Oct 15, 2024

🙈 The PR is closed and the preview is expired.

@MichalMaler MichalMaler added the area/docstyle issues related for manual docstyle review label Oct 15, 2024
@MichalMaler
Copy link
Contributor Author

This will need to be backported to 3.15.

@MichalMaler MichalMaler requested a review from jmartisk October 16, 2024 10:07
Copy link
Contributor

@jmartisk jmartisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not particularly happy about this being in the upstream docs, but... yeah. If it's a product requirement that we can't achieve in other ways...

(If we go on adding these things, I'm scared it may explode horribly)

@MichalMaler MichalMaler requested review from rolfedh and removed request for gsmet October 16, 2024 12:05
@MichalMaler
Copy link
Contributor Author

@jmartisk @cescoffier
Hello!

  1. This is just a cosmetic PR and the follow-up of:
  1. Look, I don't like it either, but when Quarkus and downstreamed product differ in what is supported and allowed, there is simply no other option.

Moreover, any activities related to tooling and scripting have been prohibited (for us, writers), so these workarounds using attributes, #ifdef, and #ifndef conditionals are the only way to maintain the rendered Quarkus as it is while obtaining different behavior in RHBQ.

Please merge if there are no other objections. I am also for finding of a better solution in the future, but Quarkus dev help will be required. This is the best the docs team can do on their own.

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit. LGTM


TLS Registry also provides automatic certificate reloading
ifndef::no-lets-encrypt[]
, integration with Let's Encrypt (ACME)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed since the , you are suggesting here is present in the next line:
image

@jmartisk jmartisk merged commit 892d4a3 into quarkusio:main Oct 16, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 16, 2024
@MichalMaler MichalMaler deleted the Adding-additional-conditionals-for-the-TLS-guide branch October 16, 2024 13:42
@gsmet gsmet modified the milestones: 3.17 - main, 3.15.2 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants