Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute Character Escapes for Json Content #43900

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ogomezdi
Copy link

Changes for covering JSON Escapes in templates mentioned in issue #43369

@quarkus-bot quarkus-bot bot added area/documentation area/qute The template engine labels Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

🎊 PR Preview 8df922d has been successfully built and deployed to https://quarkus-pr-main-43900-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@ogomezdi ogomezdi marked this pull request as ready for review November 21, 2024 17:53

This comment has been minimized.

Copy link

quarkus-bot bot commented Nov 22, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 9cdd33f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Nov 22, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9cdd33f.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 17 Build Failures Logs Raw logs 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: independent-projects/qute/core 
! Skipped: core/deployment core/runtime devtools/cli and 866 more

📦 independent-projects/qute/core

io.quarkus.qute.JsonEscaperTest.testEscaping line 59 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <\rČolek\n;> but was: <\rČolek\n>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
	at io.quarkus.qute.JsonEscaperTest.testEscaping(JsonEscaperTest.java:59)

⚙️ JVM Tests - JDK 21 #

- Failing: independent-projects/qute/core 
! Skipped: core/deployment core/runtime devtools/cli and 866 more

📦 independent-projects/qute/core

io.quarkus.qute.JsonEscaperTest.testEscaping line 59 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <\rČolek\n;> but was: <\rČolek\n>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
	at io.quarkus.qute.JsonEscaperTest.testEscaping(JsonEscaperTest.java:59)

⚙️ JVM Tests - JDK 17 Windows #

- Failing: independent-projects/qute/core 
! Skipped: core/deployment core/runtime devtools/cli and 866 more

📦 independent-projects/qute/core

io.quarkus.qute.JsonEscaperTest.testEscaping line 59 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <\rČolek\n;> but was: <\rČolek\n>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
	at io.quarkus.qute.JsonEscaperTest.testEscaping(JsonEscaperTest.java:59)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant