Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "suspend" param to control the debug mode launch #4395

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Add "suspend" param to control the debug mode launch #4395

merged 1 commit into from
Oct 7, 2019

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Oct 6, 2019

As recommened in this PR #4353, the commit here introduces a suspend param to the DevModeMojo to allow control over how the JVM is launched in debug mode. This param is defaulted to n to allow the usecase noted here #3316 (comment)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks. I added one small comment about the doc. Can you have a look?

devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java Outdated Show resolved Hide resolved
@gsmet gsmet merged commit 2df18ec into quarkusio:master Oct 7, 2019
@gsmet
Copy link
Member

gsmet commented Oct 7, 2019

Merged, thanks!

@geoand
Copy link
Contributor

geoand commented Oct 17, 2019

@jaikiran I think it makes sense to do the same modification and doc update Gradle. Would you like to take care of that?

@jaikiran
Copy link
Member Author

@jaikiran I think it makes sense to do the same modification and doc update Gradle. Would you like to take care of that?

@geoand I just submitted a PR for this #4631. I haven't yet had a chance to test it out but I can do some manual testing later tonight when I find some time.

@geoand
Copy link
Contributor

geoand commented Oct 17, 2019

@jaikiran Thanks!

@jaikiran jaikiran deleted the devmode-debug-suspend branch October 17, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants