Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Junit5 - inner classes are not allowed as they cannot become managed … #4409

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Junit5 - inner classes are not allowed as they cannot become managed … #4409

merged 1 commit into from
Oct 7, 2019

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Oct 7, 2019

…beans.

I tried to write an automated test too, but I don't think we have a way to assert failure during junit extension processing, right @geoand ?

@manovotn manovotn requested a review from geoand October 7, 2019 11:10
@manovotn
Copy link
Contributor Author

manovotn commented Oct 7, 2019

Fixes #4393

@geoand
Copy link
Contributor

geoand commented Oct 7, 2019

@manovotn not that I know of anyway :)

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 7, 2019
@geoand
Copy link
Contributor

geoand commented Oct 7, 2019

Thanks for taking care of this @manovotn !

@geoand geoand merged commit ac12af9 into quarkusio:master Oct 7, 2019
@geoand geoand added this to the 0.24.0 milestone Oct 7, 2019
@famod famod mentioned this pull request Aug 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manovotn @geoand