Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIDC Bearer tutorial link name #44163

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

sberyozkin
Copy link
Member

CC @jedla97 @rolfedh

OIDC bearer token authentication ref doc links to the bearer token authentication tutorial but uses a wrong name for the link

@sberyozkin sberyozkin requested a review from gastaldi October 29, 2024 12:19
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Oct 29, 2024
@sberyozkin sberyozkin mentioned this pull request Oct 29, 2024
@sberyozkin
Copy link
Member Author

@rolfedh Sorry, I closed #44162 as I thought it was a duplicate, but then I noticed you also collapsed it all into a single sentence, would like me to do it here as well now ? May be we should do it later as other OIDC docs may need a similar update ?

@rolfedh
Copy link
Contributor

rolfedh commented Oct 29, 2024

@rolfedh Sorry, I closed #44162 as I thought it was a duplicate, but then I noticed you also collapsed it all into a single sentence, would like me to do it here as well now ? May be we should do it later as other OIDC docs may need a similar update ?

No that's a minor stylistic tweak. Not necessary.

@sberyozkin
Copy link
Member Author

OK, thanks @rolfedh, sorry again for closing your PR which came first :-), I did not realize both of us tried to fix the issue, thanks

@sberyozkin sberyozkin merged commit 4b6211c into quarkusio:main Oct 29, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 29, 2024
@sberyozkin sberyozkin deleted the fix_oidc_bearer_doc_link_name branch October 29, 2024 12:50
Copy link

github-actions bot commented Oct 29, 2024

🙈 The PR is closed and the preview is expired.

@rolfedh
Copy link
Contributor

rolfedh commented Oct 29, 2024

OK, thanks @rolfedh, sorry again for closing your PR which came first :-), I did not realize both of us tried to fix the issue, thanks

No worries at all. Thanks for fixing it quickly.

@gsmet gsmet modified the milestones: 3.17 - main, 3.16.1 Oct 29, 2024
@rsvoboda rsvoboda modified the milestones: 3.16.1, 3.15.2 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants