Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial copy of Derby extension #4424

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Initial copy of Derby extension #4424

merged 3 commits into from
Oct 14, 2019

Conversation

aguibert
Copy link
Member

@aguibert aguibert commented Oct 7, 2019 •
edited
Loading

Working directly with @Sanne on this, but anyone is welcome to commend and discuss!

Fixes #4442

@stuartwdouglas
Copy link
Member

Looks like format validation failed. Can you run 'mvn process-sources' and push an amended commit?

We have really strict formatting rules but the default maven build automatically formats, so if you build from maven before pushing you should not run into this again.

@aguibert
Copy link
Member Author

aguibert commented Oct 8, 2019

Thanks for the review comments already @stuartwdouglas and @cescoffier! This PR was just a draft so not fully polished yet, but I appreciate you guys taking the time to look it over in the early stages.

@aguibert
Copy link
Member Author

aguibert commented Oct 8, 2019

@stuartwdouglas I have been running various flavors of mvn install a lot on the projects I am contributing, I assume the formatting goal would be part of this chain? I also tried running mvn process-sources in /quarkus/extensions/jdbc/jdbc-derby and /quarkus/integration-tests/jpa-derby/ but it did modify any of the files.

I'm not too familiar with azure pipelines, but I take it the formatting failure is described somewhere in the build output? I've tried to view the build results myself (specifically this link) but it's not loading for me -- perhaps they have been auto-deleted by now?

@aguibert aguibert mentioned this pull request Oct 8, 2019
Closed
gsmet
gsmet previously requested changes Oct 8, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me (hi Andy!). I added a couple of comments here and there.

core/deployment/src/main/java/io/quarkus/deployment/builditem/FeatureBuildItem.java Outdated Show resolved Hide resolved
...bc-derby-deployment/src/main/java/io/quarkus/jdbc/derby/deployment/DerbyJDBCReflections.java Outdated Show resolved Hide resolved
...jdbc-derby-deployment/src/main/java/io/quarkus/jdbc/derby/deployment/JDBCDerbyProcessor.java Show resolved Hide resolved
.../src/main/java/io/quarkus/jdbc/derby/runtime/graal/ClientDriver_PlaceholderSubstitution.java Outdated Show resolved Hide resolved
integration-tests/jpa-derby/.gitignore Outdated Show resolved Hide resolved
integration-tests/jpa-derby/pom.xml Outdated Show resolved Hide resolved
@stuartwdouglas
Copy link
Member

That link worked fine for me, AFAIK the results should be public so you should be able to see them as well. To see the logs you need to click on the 'Linux Maven Repo' task.

If you run mvn install it should auto format for you. I also use the following in '.git/hooks/pre-push'

#!/bin/sh
mvn process-sources -Dno-format -Denforcer.skip -Dmaven.buildNumber.skip

This will check before pushing (if you want to save time as you know it is ok you can use --no-verify when you push)

@aguibert aguibert marked this pull request as ready for review October 11, 2019 22:23
@aguibert
Copy link
Member Author

PR is now updated with all review comment feedback, as well as CI checks passing.

@Sanne @cescoffier @gsmet please re-review when you get a chance. Thanks!

cescoffier
cescoffier reviewed Oct 14, 2019
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'm not a database guy.
Will let @Sanne do more meaningful comments

machi1990
machi1990 reviewed Oct 14, 2019
View reviewed changes
core/deployment/src/main/java/io/quarkus/deployment/builditem/FeatureBuildItem.java
public static final String JDBC_POSTGRESQL = "jdbc-postgresql";
public static final String JDBC_MARIADB = "jdbc-mariadb";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a very minor comment - I think the constants are sorted in alphabetically. We should preserve that :-)

Sanne
Sanne approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@Sanne Sanne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ready to go! Just missed to mention the new Maven modules in the respective parents, I added that.

Thanks!

@Sanne Sanne dismissed stale reviews from gsmet and cescoffier October 14, 2019 17:37

Comments addressed

@Sanne Sanne merged commit 9dcaa18 into quarkusio:master Oct 14, 2019
@Sanne Sanne added this to the 0.25.0 milestone Oct 14, 2019
@aguibert aguibert mentioned this pull request Oct 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 left review comments

@cescoffier cescoffier cescoffier left review comments

@Sanne Sanne Sanne approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
kind/enhancement New feature or request release/noteworthy-feature
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

Quarkus support for Derby
6 participants
@aguibert @stuartwdouglas @Sanne @cescoffier @gsmet @machi1990