Periodically validate JDBC connections #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agroal uses ConnectionValidator.emptyValidator() by default, so even if we set the default validation interval to 2 minutes by default, it will just do nothing every 2 minutes. Fixes quarkusio#2336
gsmet
approved these changes
Oct 8, 2019
gsmet
added
the
triage/waiting-for-ci
|
thanks @yrodiere ! |
|
Windows failure is unrelated, I'll merge this. Thanks @yrodiere ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2336
Agroal uses
ConnectionValidator.emptyValidator()by default,so even if we set the default validation interval to 2 minutes by
default, it will just do nothing every 2 minutes.
Tested manually by putting a thread-suspending breakpoint on the line
storeTestPersons(entityManagerFactory);inJPAFunctionalityTestEndpoint.Just run
io.quarkus.it.jpa.mariadb.JPAFunctionalityTest, and when the breakpoint is hit, restart the database, wait 2 minutes, and resume execution. Before this patch, the call tostoreTestPersons(entityManagerFactory);would fail because a stale connection was in the ppol; after this patch, it will succeed because the connection was removed and renewed.