Support for short and uncommon field names like set, get, and is #44457

burl21 · 2024-11-12T21:04:46Z

fix: #44433
Enhance handling of short field names specifically for records, ensuring correct support for fields like set, get, and is.

quarkus-bot · 2024-11-12T21:04:49Z

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

title should not end up with dot

_{This message is automatically generated by a bot.}

gsmet · 2024-11-13T08:55:11Z

/cc @mariofusco

mariofusco · 2024-11-13T09:00:29Z

...ain/java/io/quarkus/resteasy/reactive/jackson/deployment/processor/JacksonCodeGenerator.java

@@ -281,7 +281,7 @@ private Type fieldType() {
            if (isPublicField()) {
                return fieldInfo.type();
            }
-            if (methodInfo.name().startsWith("set")) {
+            if (methodInfo.parametersCount() == 1 && methodInfo.name().startsWith("set")) {


...ain/java/io/quarkus/resteasy/reactive/jackson/deployment/processor/JacksonCodeGenerator.java

mariofusco

@burl21 Thanks a lot for this fix, I'd just prefer to keep it more confined to the "set", "get" and "is" field name it is supposed to support, so please see my suggestion.

gsmet

I rebased and squashed the commits. Let's wait for CI and merge!

Thanks!

quarkus-bot · 2024-11-13T10:51:32Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 7bbb0a8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

gsmet · 2024-11-13T17:58:25Z

Merged, thanks for your contribution.

The fix will land in 3.16.4 that we will release next week.

…oud-jsonlogging!25) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.quarkus:quarkus-extension-processor](https://github.com/quarkusio/quarkus) | | minor | `3.16.3` -> `3.17.0` | | [io.quarkus:quarkus-extension-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.16.3` -> `3.17.0` | | [io.quarkus:quarkus-bom](https://github.com/quarkusio/quarkus) | import | minor | `3.16.3` -> `3.17.0` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.16.3` -> `3.17.0` | | [org.jboss.logmanager:jboss-logmanager](https://jboss.org) ([source](https://github.com/jboss-logging/jboss-logmanager)) | optional | minor | `3.0.6.Final` -> `3.1.0.Final` | --- ### Release Notes <details> <summary>quarkusio/quarkus</summary> ### [`v3.17.0`](quarkusio/quarkus@3.16.4...3.17.0) [Compare Source](quarkusio/quarkus@3.16.4...3.17.0) ### [`v3.16.4`](https://github.com/quarkusio/quarkus/releases/tag/3.16.4) [Compare Source](quarkusio/quarkus@3.16.3...3.16.4) ##### Complete changelog - [#37040](quarkusio/quarkus#37040) - The flyway extension generates Kubernetes resources as if quarkus.flyway.enabled was a runtime property - [#42446](quarkusio/quarkus#42446) - Add explanation/concept for extension maturity model - [#44367](quarkusio/quarkus#44367) - Gradle 3.16 fails with missing required property `additionalForcedProperties` - [#44399](quarkusio/quarkus#44399) - Declaring explicitly the build service in the QuarkusBuildTask - [#44433](quarkusio/quarkus#44433) - Reflection free serializers ArrayIndexOutOfBoundsException - [#44438](quarkusio/quarkus#44438) - Gradle `buildForkOptions` no longer used since quarkus 3.16.1 - [#44457](quarkusio/quarkus#44457) - Support for short and uncommon field names like set, get, and is - [#44468](quarkusio/quarkus#44468) - Use `QUARKUS_FLYWAY_ACTIVE` instead of `QUARKUS_FLYWAY_ENABLED` env in Kubernetes resources - [#44472](quarkusio/quarkus#44472) - Kotlin native Jackson serialization regression: EmptyList & EmptyMap missing - [#44480](quarkusio/quarkus#44480) - Fix nullpointer on null code websockets-next - [#44493](quarkusio/quarkus#44493) - Using BuildForkOptions in QuarkusBuildTask - [#44494](quarkusio/quarkus#44494) - Register Kotlin's empty list and map for reflection - [#44505](quarkusio/quarkus#44505) - Log in smallrye-jwt and oauth2 extensions when no bearer access token is available - [#44507](quarkusio/quarkus#44507) - Fixed Timestamp not being set for otel log signals - [#44509](quarkusio/quarkus#44509) - Updates to Infinispan 15.0.11.Final - [#44515](quarkusio/quarkus#44515) - Coordinated Vert.x 4.5.11 upgrades - [#44531](quarkusio/quarkus#44531) - Correct image file name to resolve broken image - [#44537](quarkusio/quarkus#44537) - Update smallrye-jwt to 4.6.1 - [#44545](quarkusio/quarkus#44545) - Wrong index of ParameterizedType argument of Map when register type to be generated in JacksonCodeGenerator - [#44571](quarkusio/quarkus#44571) - Update `CacheJsonRPCService.java` reference - [#44574](quarkusio/quarkus#44574) - Grammar corrections for en-us </details> <details> <summary>jboss-logging/jboss-logmanager</summary> ### [`v3.1.0.Final`](https://github.com/jboss-logging/jboss-logmanager/releases/tag/v3.1.0.Final): 3.1.0.Final [Compare Source](jboss-logging/jboss-logmanager@3.0.6.Final...v3.1.0.Final) #### What's Changed - \[LOGMGR-345] Ensure logger FQCN is correct for system logger by [@dmlloyd](https://github.com/dmlloyd) in jboss-logging/jboss-logmanager#457 - Migrate tests to keep the log files that were created. Put the log fi… by [@jamezp](https://github.com/jamezp) in jboss-logging/jboss-logmanager#459 - Bump org.junit:junit-bom from 5.10.1 to 5.10.2 by [@dependabot](https://github.com/dependabot) in jboss-logging/jboss-logmanager#461 - \[LOGMGR-346] Bump org.jboss.modules:jboss-modules from 2.1.2.Final to 2.1.3.Final by [@dependabot](https://github.com/dependabot) in jboss-logging/jboss-logmanager#462 - \[LOGMGR-347] Do not use deprecated SmallRye Common OS `Process` by [@dmlloyd](https://github.com/dmlloyd) in jboss-logging/jboss-logmanager#464 - \[LOGMGR-349] Bump org.eclipse.parsson:parsson from 1.1.5 to 1.1.6 by [@dependabot](https://github.com/dependabot) in jboss-logging/jboss-logmanager#466 - \[LOGMGR-351] Fix periodic file rotation by week, month, year. by [@alex-pumpkin](https://github.com/alex-pumpkin) in jboss-logging/jboss-logmanager#468 - Bump org.jboss.modules:jboss-modules from 2.1.3.Final to 2.1.5.Final by [@dependabot](https://github.com/dependabot) in jboss-logging/jboss-logmanager#467 - \[LOGMGR-350] Avoid TCCL when configuring the log manager by [@dmlloyd](https://github.com/dmlloyd) in jboss-logging/jboss-logmanager#469 - \[LOGMGR-351] Remove the deprecated per-deployment logging options. by [@jamezp](https://github.com/jamezp) in jboss-logging/jboss-logmanager#471 - Bump org.junit:junit-bom from 5.10.2 to 5.10.3 by [@dependabot](https://github.com/dependabot) in jboss-logging/jboss-logmanager#478 - Bump org.jboss.byteman:byteman-bmunit5 from 4.0.22 to 4.0.23 by [@dependabot](https://github.com/dependabot) in jboss-logging/jboss-logmanager#476 - Bump org.junit:junit-bom from 5.10.3 to 5.11.2 by [@dependabot](https://github.com/dependabot) in jboss-logging/jboss-logmanager#488 - Bump org.junit:junit-bom from 5.11.2 to 5.11.3 by [@dependabot](https://github.com/dependabot) in jboss-logging/jboss-logmanager#490 - \[LOGMGR-354] Avoid expensive JLine setup on JDK 23+ by [@dmlloyd](https://github.com/dmlloyd) in jboss-logging/jboss-logmanager#491 - Save head encoding on sanitized String(s) by [@franz1981](https://github.com/franz1981) in jboss-logging/jboss-logmanager#492 - Use `NO_FORMAT` when using parameterless log methods by [@dmlloyd](https://github.com/dmlloyd) in jboss-logging/jboss-logmanager#493 - Switch to formal module descriptor by [@dmlloyd](https://github.com/dmlloyd) in jboss-logging/jboss-logmanager#494 - Module descriptor updates by [@dmlloyd](https://github.com/dmlloyd) in jboss-logging/jboss-logmanager#496 - Bump org.jboss.modules:jboss-modules from 2.1.5.Final to 2.1.6.Final by [@dependabot](https://github.com/dependabot) in jboss-logging/jboss-logmanager#495 - Add smart service provider method by [@dmlloyd](https://github.com/dmlloyd) in jboss-logging/jboss-logmanager#497 #### New Contributors - [@alex-pumpkin](https://github.com/alex-pumpkin) made their first contribution in jboss-logging/jboss-logmanager#468 - [@franz1981](https://github.com/franz1981) made their first contribution in jboss-logging/jboss-logmanager#492 **Full Changelog**: jboss-logging/jboss-logmanager@3.0.4.Final...v3.1.0.Final </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

quarkus-bot bot added the area/rest label Nov 12, 2024

burl21 changed the title ~~Support for short and uncommon field names like set, get, and is.~~ Support for short and uncommon field names like set, get, and is Nov 12, 2024

mariofusco reviewed Nov 13, 2024

View reviewed changes

...ain/java/io/quarkus/resteasy/reactive/jackson/deployment/processor/JacksonCodeGenerator.java Outdated Show resolved Hide resolved

mariofusco suggested changes Nov 13, 2024

View reviewed changes

mariofusco approved these changes Nov 13, 2024

View reviewed changes

fix: support for short and uncommon field names like set, get, and is.

7bbb0a8

gsmet force-pushed the #44433 branch from 7ea9350 to 7bbb0a8 Compare November 13, 2024 09:39

gsmet approved these changes Nov 13, 2024

View reviewed changes

gsmet added triage/backport-3.16 triage/backport labels Nov 13, 2024

gsmet merged commit 7fa4088 into quarkusio:main Nov 13, 2024
32 checks passed

quarkus-bot bot added this to the 3.18 - main milestone Nov 13, 2024

quarkus-bot bot added the kind/bugfix label Nov 13, 2024

gsmet modified the milestones: 3.18 - main, 3.16.4 Nov 19, 2024

gsmet removed triage/backport-3.16 triage/backport labels Nov 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for short and uncommon field names like set, get, and is #44457

Support for short and uncommon field names like set, get, and is #44457

burl21 commented Nov 12, 2024

quarkus-bot bot commented Nov 12, 2024

gsmet commented Nov 13, 2024

mariofusco Nov 13, 2024

mariofusco left a comment

gsmet left a comment

quarkus-bot bot commented Nov 13, 2024 •

edited by github-actions bot

Loading

gsmet commented Nov 13, 2024

Support for short and uncommon field names like set, get, and is #44457

Support for short and uncommon field names like set, get, and is #44457

Conversation

burl21 commented Nov 12, 2024

quarkus-bot bot commented Nov 12, 2024

gsmet commented Nov 13, 2024

mariofusco Nov 13, 2024

Choose a reason for hiding this comment

mariofusco left a comment

Choose a reason for hiding this comment

gsmet left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Nov 13, 2024 • edited by github-actions bot Loading

Status for workflow Quarkus CI

gsmet commented Nov 13, 2024

quarkus-bot bot commented Nov 13, 2024 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`