Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Quartz 2.5.0 and drop Jakarta transformation workaround #44477

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 13, 2024

Damn, that feels good to finally be able to get rid of the transformation workaround!

@gsmet gsmet requested a review from mkouba November 13, 2024 16:23
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/scheduler labels Nov 13, 2024
@gsmet
Copy link
Member Author

gsmet commented Nov 13, 2024

/cc @melloware thanks for being pushy about this!

Copy link

github-actions bot commented Nov 13, 2024

🎊 PR Preview 7fa4088 has been successfully built and deployed to https://quarkus-pr-main-44477-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

@manofthepeace
Copy link
Contributor

in extension/quartz/runtime/pom.xml. There are exculsiosn on quartz that I do not think are needed anymore; HikariCP and c3p0 are now provided dependencies instead of compile dependencies. Also I am guessing HikariCP-java7 is not there anymore (did not check)

        <dependency>
            <groupId>org.quartz-scheduler</groupId>
            <artifactId>quartz</artifactId>
            <exclusions>
                <exclusion>
                    <groupId>com.zaxxer</groupId>
                    <artifactId>HikariCP</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>com.zaxxer</groupId>
                    <artifactId>HikariCP-java7</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>com.mchange</groupId>
                    <artifactId>c3p0</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

@gsmet
Copy link
Member Author

gsmet commented Nov 13, 2024

Ah good catch, let me have a look.

Copy link

quarkus-bot bot commented Nov 13, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 64e9ad7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Nov 14, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 64e9ad7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.metrics.HttpServerMetricsTest.collectsHttpRouteFromEndAttributes - History

  • Expected size: 2 but was: 1 in: [ImmutableHistogramPointData{getStartEpochNanos=1731530207330833809, getEpochNanos=1731530208233721463, getAttributes={http.request.method="GET", http.response.status_code=200, http.route="/span", url.scheme="http"}, getSum=0.06727615, getCount=1, hasMin=true, getMin=0.06727615, hasMax=true, getMax=0.06727615, getBoundaries=[0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1.0, 2.5, 5.0, 7.5, 10.0], getCounts=[0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], getExemplars=[ImmutableDoubleExemplarData{filteredAttributes={client.address="127.0.0.1", http.response.body.size=5, server.address="localhost", server.port=8081, url.path="/span", user_agent.original="Apache-HttpClient/4.5.14 (Java/17.0.13)"}, epochNanos=1731530208202000000, spanContext=ImmutableSpanContext{traceId=12cf5edeff6bad25cefcd344f35a5359, spanId=e6fdbdfb4e62f08c, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, value=0.06727615}]}] - java.lang.AssertionError
java.lang.AssertionError: 

Expected size: 2 but was: 1 in:
[ImmutableHistogramPointData{getStartEpochNanos=1731530207330833809, getEpochNanos=1731530208233721463, getAttributes={http.request.method="GET", http.response.status_code=200, http.route="/span", url.scheme="http"}, getSum=0.06727615, getCount=1, hasMin=true, getMin=0.06727615, hasMax=true, getMax=0.06727615, getBoundaries=[0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1.0, 2.5, 5.0, 7.5, 10.0], getCounts=[0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], getExemplars=[ImmutableDoubleExemplarData{filteredAttributes={client.address="127.0.0.1", http.response.body.size=5, server.address="localhost", server.port=8081, url.path="/span", user_agent.original="Apache-HttpClient/4.5.14 (Java/17.0.13)"}, epochNanos=1731530208202000000, spanContext=ImmutableSpanContext{traceId=12cf5edeff6bad25cefcd344f35a5359, spanId=e6fdbdfb4e62f08c, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, value=0...
  • Expected size: 2 but was: 1 in: [ImmutableHistogramPointData{getStartEpochNanos=1731530268692583078, getEpochNanos=1731530269595315099, getAttributes={http.request.method="GET", http.response.status_code=200, http.route="/span", url.scheme="http"}, getSum=0.062845003, getCount=1, hasMin=true, getMin=0.062845003, hasMax=true, getMax=0.062845003, getBoundaries=[0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1.0, 2.5, 5.0, 7.5, 10.0], getCounts=[0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], getExemplars=[ImmutableDoubleExemplarData{filteredAttributes={client.address="127.0.0.1", http.response.body.size=5, server.address="localhost", server.port=8081, url.path="/span", user_agent.original="Apache-HttpClient/4.5.14 (Java/17.0.13)"}, epochNanos=1731530269558000000, spanContext=ImmutableSpanContext{traceId=1f0340936e05f4d45fc2be41c1b113ee, spanId=b5dcbac954dffe67, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, value=0.062845003}]}] - java.lang.AssertionError
java.lang.AssertionError: 

Expected size: 2 but was: 1 in:
[ImmutableHistogramPointData{getStartEpochNanos=1731530268692583078, getEpochNanos=1731530269595315099, getAttributes={http.request.method="GET", http.response.status_code=200, http.route="/span", url.scheme="http"}, getSum=0.062845003, getCount=1, hasMin=true, getMin=0.062845003, hasMax=true, getMax=0.062845003, getBoundaries=[0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1.0, 2.5, 5.0, 7.5, 10.0], getCounts=[0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], getExemplars=[ImmutableDoubleExemplarData{filteredAttributes={client.address="127.0.0.1", http.response.body.size=5, server.address="localhost", server.port=8081, url.path="/span", user_agent.original="Apache-HttpClient/4.5.14 (Java/17.0.13)"}, epochNanos=1731530269558000000, spanContext=ImmutableSpanContext{traceId=1f0340936e05f4d45fc2be41c1b113ee, spanId=b5dcbac954dffe67, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, valu...
  • Expected size: 2 but was: 1 in: [ImmutableHistogramPointData{getStartEpochNanos=1731530272266444640, getEpochNanos=1731530273169308908, getAttributes={http.request.method="GET", http.response.status_code=200, http.route="/span", url.scheme="http"}, getSum=0.0681524, getCount=1, hasMin=true, getMin=0.0681524, hasMax=true, getMax=0.0681524, getBoundaries=[0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1.0, 2.5, 5.0, 7.5, 10.0], getCounts=[0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], getExemplars=[ImmutableDoubleExemplarData{filteredAttributes={client.address="127.0.0.1", http.response.body.size=5, server.address="localhost", server.port=8081, url.path="/span", user_agent.original="Apache-HttpClient/4.5.14 (Java/17.0.13)"}, epochNanos=1731530273133000000, spanContext=ImmutableSpanContext{traceId=1c453e362767c495879e561eda20aefc, spanId=78e99da85ed145df, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, value=0.0681524}]}] - java.lang.AssertionError
java.lang.AssertionError: 

Expected size: 2 but was: 1 in:
[ImmutableHistogramPointData{getStartEpochNanos=1731530272266444640, getEpochNanos=1731530273169308908, getAttributes={http.request.method="GET", http.response.status_code=200, http.route="/span", url.scheme="http"}, getSum=0.0681524, getCount=1, hasMin=true, getMin=0.0681524, hasMax=true, getMax=0.0681524, getBoundaries=[0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1.0, 2.5, 5.0, 7.5, 10.0], getCounts=[0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], getExemplars=[ImmutableDoubleExemplarData{filteredAttributes={client.address="127.0.0.1", http.response.body.size=5, server.address="localhost", server.port=8081, url.path="/span", user_agent.original="Apache-HttpClient/4.5.14 (Java/17.0.13)"}, epochNanos=1731530273133000000, spanContext=ImmutableSpanContext{traceId=1c453e362767c495879e561eda20aefc, spanId=78e99da85ed145df, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, value=0.06...

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.VertxBlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@mkouba mkouba merged commit 20dc22a into quarkusio:main Nov 14, 2024
54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 14, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.0 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/scheduler triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants