Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Serde detection for Instance injection of Messaging channels #44526

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Support Serde detection for Instance injection of Messaging channels #44526

merged 1 commit into from
Nov 15, 2024

Conversation

ozangunalp
Copy link
Contributor

Resolves #44500

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

🎊 PR Preview 69c0b8e has been successfully built and deployed to https://quarkus-pr-main-44526-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@ozangunalp ozangunalp force-pushed the serde_detection_instance_channel branch from 75fde6c to 648ae74 Compare November 15, 2024 11:07
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
Ladicek
Ladicek reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but in addition to Instance, we should also support jakarta.inject.Provider and io.quarkus.arc.InjectableInstance. These 3 types are equivalent from the perspective of autodetection, so should be straightforward.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@ozangunalp ozangunalp force-pushed the serde_detection_instance_channel branch from 648ae74 to e0b1335 Compare November 15, 2024 14:20
@ozangunalp
Copy link
Contributor Author

Indeed, I've added the io.quarkus.arc.InjectableInstance and jakarta.inject.Provider for detection.

Ladicek
Ladicek reviewed Nov 15, 2024
View reviewed changes
...test/java/io/quarkus/smallrye/reactivemessaging/kafka/deployment/DefaultSerdeConfigTest.java Outdated
@@ -881,7 +884,7 @@ public void avroDtoInGenericRecordOut() {
tuple("mp.messaging.outgoing.channel33.value.serializer", "io.apicurio.registry.serde.avro.AvroKafkaSerializer"),
tuple("mp.messaging.incoming.channel34.value.deserializer", "io.apicurio.registry.serde.avro.AvroKafkaDeserializer"),
tuple("mp.messaging.incoming.channel34.apicurio.registry.use-specific-avro-reader", "true"),
tuple("mp.messaging.outgoing.channel35.value.serializer", "io.apicurio.registry.serde.avro.AvroKafkaSerializer"),
tuple("mp.messaging.outgoing.channel35.value.serializer", "io.apcurio.registry.serde.avro.AvroKafkaSerializer"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo?

@Ladicek
Copy link
Contributor

Ladicek commented Nov 15, 2024

LGTM, but didn't approve yet due to the spotted typo (?).

@ozangunalp ozangunalp force-pushed the serde_detection_instance_channel branch from e0b1335 to c858117 Compare November 15, 2024 14:32
@ozangunalp
Copy link
Contributor Author

Thanks @Ladicek!

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 15, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c858117.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 15, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c858117.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@ozangunalp ozangunalp merged commit efcd612 into quarkusio:main Nov 15, 2024
24 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 15, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Nov 15, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.0 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
area/reactive-messaging area/smallrye kind/enhancement New feature or request
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.

Kafka serializer cannot be autodetected when injecting an Instance
3 participants
@ozangunalp @Ladicek @gsmet