Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference extension maturity matrix from extensions FAQ #44558

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Reference extension maturity matrix from extensions FAQ #44558

merged 2 commits into from
Nov 18, 2024

Conversation

holly-cummins
Copy link
Contributor

@holly-cummins holly-cummins commented Nov 18, 2024 •
edited
Loading

Now that the maturity matrix is live, we can cross-reference it from the extensions FAQ.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I pointed out might help getting the build green.

docs/src/main/asciidoc/extension-faq.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-faq.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-faq.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-faq.adoc Outdated Show resolved Hide resolved
holly-cummins and others added 2 commits November 18, 2024 12:47
@holly-cummins @gsmet
Reference maturity matrix from FAQ
14946be 
This reverts commit 693ddaf and updates 'model' to matrix

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>
@holly-cummins
Use asciidoc-style headers
ea35c4d
@holly-cummins
Copy link
Contributor Author

What I pointed out might help getting the build green.

Thanks! I've squashed, and then changed the styles of the headings in a second commit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@holly-cummins
Copy link
Contributor Author

Preview link: https://quarkus-pr-main-44558-preview.surge.sh/version/main/guides/extension-faq

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 18, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ea35c4d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

gsmet
gsmet approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@gsmet gsmet merged commit 00852eb into quarkusio:main Nov 18, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 18, 2024
@gsmet
Copy link
Member

gsmet commented Nov 18, 2024

Oh, now, I'm wondering if I should have waited 3 months to merge it? (or is it too soon to joke about it?)

@gsmet gsmet modified the milestones: 3.18 - main, 3.17.0 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@holly-cummins @gsmet