Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render ConfigMapping elements properly in the Dev UI Configuration editor #44567

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

gastaldi
Copy link
Contributor

@ConfigMapping classes are now rendered properly in the Config Editor (DevUI)

From this:
Screenshot 2024-11-18 at 21 29 13

To this:

Screenshot 2024-11-18 at 21 26 55

@phillip-kruger
Copy link
Member

Nice! This has bugged me for a while :)

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a Dev UI p.o.v. @radcortez to confirm all good from config p.o.v

Copy link

quarkus-bot bot commented Nov 19, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 811819e.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
MicroProfile TCKs Tests Verify Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-opentelemetry 

📦 tcks/microprofile-opentelemetry

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.0:test (tracing) on project quarkus-tck-microprofile-opentelemetry: There are test failures.

Please refer to /home/runner/work/quarkus/quarkus/tcks/microprofile-opentelemetry/target/surefire-reports-tracing for the individual test results.
Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.binder.VertxHttpClientMetricsTest.testWebClientMetrics - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:353)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:346)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:827)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:817)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

@gsmet
Copy link
Member

gsmet commented Nov 19, 2024

I'm not sure how it articulates with this effort: #43354 .

@radcortez
Copy link
Member

I'm not sure how it articulates with this effort: #43354 .

I think they complement each other.

@gastaldi gastaldi merged commit 259cabe into quarkusio:main Nov 19, 2024
51 of 52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 19, 2024
@gastaldi gastaldi deleted the config_editor branch November 19, 2024 11:03
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.0 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants