Do better cleanup of tests if the JVM is killed #4457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We write out all the created files to a file, and if this file is still present we know that the JVM was killed and we clean up all listed entries. Note that this can still give problems for classes that use QuarkusTestExtension, as JUnit 5 does not let us hook in before classloading.
|
@FroMage I think you have been complaining at various times about test cleanup in Eclipse? I think this might help. |
|
OK lemme try |
|
@FroMage can you check if it's OK for you? If so let's merge it and be done with it. |
|
Finally ready to test. |
|
I confirm it fixes my issue, thanks a lot! |
FroMage
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We write out all the created files to a file, and if this
file is still present we know that the JVM was killed and
we clean up all listed entries. Note that this can still
give problems for classes that use QuarkusTestExtension,
as JUnit 5 does not let us hook in before classloading.