Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong web endpoint path for resource on Windows #44584

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

jedla97
Copy link
Contributor

@jedla97 jedla97 commented Nov 19, 2024

Fixes #44576

Tested it on Windows and it worked for me. This was caused by #44128 which is marked for backport for 3.15 and was backported to 3.16.1. So for 3.15 it should be backported together.

This comment has been minimized.

@jedla97 jedla97 changed the title Fix wrong web endpoint path on Windows Fix wrong web endpoint path for resource on Windows Nov 20, 2024
The web endpoint path was created from file path which is differ on Windows.
This caused enpoint path be like `/app\index-styles.js`
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the change, squashed and force pushed.

I think we are good to go, thanks for the investigation and the fix!

@gsmet gsmet added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport-3.15 triage/backport and removed triage/backport-3.15 labels Nov 20, 2024
Copy link

quarkus-bot bot commented Nov 20, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f9dbe64.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit c872c3b into quarkusio:main Nov 20, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 20, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 20, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.1 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env/windows Impacts Windows machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build TODO demo app on windows into uber-jar since quarkus 3.16.1
3 participants