Initial doc for Elytron Security JDBC #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course @sberyozkin @gsmet you reviews are welcome. |
gsmet
requested changes
Oct 9, 2019
|
@gsmet quickstart update to remove the "using' preffix |
gsmet
reviewed
Oct 9, 2019
danielpetisme
force-pushed
the
doc-elytron-security-jdbc
branch
from
2c9e962
to
3089cf0
Compare
|
@gsmet I'm done |
|
@danielpetisme we're nearly there! Could you rebase properly on top of master? There is a commit from Stuart in the PR which is already on master. Thanks! |
danielpetisme
force-pushed
the
doc-elytron-security-jdbc
branch
from
3089cf0
to
5504ed1
Compare
|
Sorry, should be better now |
gsmet
force-pushed
the
doc-elytron-security-jdbc
branch
from
5504ed1
to
3744f7c
Compare
gsmet
approved these changes
Oct 10, 2019
|
I force pushed a minor change as I removed JSON from the quickstart (you had a warning at startup related to that). |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for #4273
@stuartwdouglas I took the liberty of opening the PR directly in the main repo.
I think it's important to flag the feature has "Done".