Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up effects of test profiles when @QuarkusMainTest completes #44638

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Clean up effects of test profiles when @QuarkusMainTest completes #44638

merged 1 commit into from
Nov 25, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Nov 22, 2024 •
edited
Loading

P.S. Opening as a draft as I want CI to run on my fork first

@geoand
Copy link
Contributor Author

geoand commented Nov 22, 2024 •
edited
Loading

There are a few failures in BeforeEachLaunchTest and PicoCliTest Fixed

@geoand geoand marked this pull request as ready for review November 25, 2024 07:00
@geoand geoand requested a review from radcortez November 25, 2024 08:47
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 25, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 71804eb.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 9361824 into quarkusio:main Nov 25, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 25, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Nov 25, 2024
@geoand geoand deleted the #44117 branch November 25, 2024 13:33
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.1 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radcortez radcortez radcortez approved these changes

Assignees
No one assigned
Labels
area/testing kind/enhancement New feature or request
Projects
None yet
Milestone
3.17.2
Development

Successfully merging this pull request may close these issues.

TestProfile's getEnabledAlternatives CDI BEAN leaks to unrelated TestProfile's test
3 participants
@geoand @radcortez @gsmet