You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that these two issues were preexisting to the rewrite. I noticed them this week-end when I had a look at the config doc of quarkus.native.resources.includes to help a user.
I'm pretty sure it was a problem in other areas as well as things were quite wrong as soon as you had inline tags.
Also HTML tables were completely ignored and rendering raw text.
Converting HTML to Asciidoc using the Javadoc elements was causing
issues as the HTML would be split and the fragments would be handled
without the knowledge of the HTML tree.
@zakkak FYI the doc for quarkus.native.resources.includes was extremely bad due to some limitations/bugs of our historical HTML Javadoc -> Asciidoc transformation. It should be much better after this PR (noticed that when I checked the doc when discussing the Vert.x OpenAPI JSON schema thingy this week-end).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gastaldi
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Note that these two issues were preexisting to the rewrite. I noticed them this week-end when I had a look at the config doc of
quarkus.native.resources.includesto help a user.I'm pretty sure it was a problem in other areas as well as things were quite wrong as soon as you had inline tags.
Also HTML tables were completely ignored and rendering raw text.
Before:
After (AsciiDoc local build):