Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove line #44684

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Remove line #44684

merged 1 commit into from
Nov 25, 2024

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Nov 25, 2024

Remove lines introduced by #44603 which interferes with the tab that shows how to add the dependency using build.gradle.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When making significant changes like you did in the previous PR to a guide, please make sure you check the output before creating the PR as it's quite easy to break something. Thanks!

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rolfedh @gsmet

@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 25, 2024

When making significant changes like you did in the previous PR to a guide, please make sure you check the output before creating the PR as it's quite easy to break something. Thanks!

Yes, absolutely. The missing second tab slipped past me during the initial inspection of the first PR but was caught in subsequent reviews. Moving forward, I’ll make sure to check for continuity in the number of tabs and ensure no extra lines are inserted between these types of code blocks. Thanks for pointing it out!

@gastaldi gastaldi merged commit 2e78f7a into quarkusio:main Nov 25, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

🎊 PR Preview 9361824 has been successfully built and deployed to https://quarkus-pr-main-44684-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants