-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable OIDC wiremock tests using expired certificates #44760
Temporarily disable OIDC wiremock tests using expired certificates #44760
Conversation
Status for workflow
|
@@ -61,6 +62,7 @@ public void testSecureAccessSuccessPreferredUsername() { | |||
} | |||
|
|||
@Test | |||
@Disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably set the value of the annotation to specify the reason why they are disabled, but let's not waste CI :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably set the value of the annotation to specify the reason why they are disabled, but let's not waste CI :)
Sorry, you are right, I just did a quick disabling yesterday evening to minimize the disruption, and we'll be discussing now how to re-enable them effectively asap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem
@sberyozkin could we fix the issue in a way that it doesn't happen again? Because if we don't, that means that it will be impossible to run the tests in old branches at some point, which is not really acceptable. Also we will need to fix this issue in all supported branches. |
A few OIDC wiremock tests which use expired certificates (which I wrongly assumed was not the case) are failing.
I'll open an issue to reopen them