Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable OIDC wiremock tests using expired certificates #44760

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

sberyozkin
Copy link
Member

A few OIDC wiremock tests which use expired certificates (which I wrongly assumed was not the case) are failing.

I'll open an issue to reopen them

Copy link

quarkus-bot bot commented Nov 27, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7fab958.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@@ -61,6 +62,7 @@ public void testSecureAccessSuccessPreferredUsername() {
}

@Test
@Disabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably set the value of the annotation to specify the reason why they are disabled, but let's not waste CI :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geoand

We probably set the value of the annotation to specify the reason why they are disabled, but let's not waste CI :)

Sorry, you are right, I just did a quick disabling yesterday evening to minimize the disruption, and we'll be discussing now how to re-enable them effectively asap

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem

@geoand geoand merged commit 070153e into quarkusio:main Nov 27, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 27, 2024
@gsmet
Copy link
Member

gsmet commented Nov 27, 2024

@sberyozkin could we fix the issue in a way that it doesn't happen again? Because if we don't, that means that it will be impossible to run the tests in old branches at some point, which is not really acceptable.

Also we will need to fix this issue in all supported branches.

@sberyozkin sberyozkin deleted the temp_disable_some_oidc_tests branch November 27, 2024 09:46
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.1 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants