Upgrade Hibernate Search to 6.0.0.Beta1 #4478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Oct 9, 2019
This configuration was already obsolete in 6.0.0.Alpha9.
It's really not something you would use in a real-world application.
yrodiere
force-pushed
the
hsearch-6-0-0-beta1
branch
from
fc0e777
to
664cb76
Compare
gsmet
approved these changes
Oct 14, 2019
|
Merged, thanks. I'm not entirely convinced by the config changes but you're the man. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gsmet
I also added a small change to how the predicate is built, following our discussion the other day. Feel free to remove that change if you think it's too complex.
Also, as discussed over Zulip, I had to add a commit to workaround https://hibernate.atlassian.net/browse/HSEARCH-3734 . Without this commit, native mode just won't work.