Fix #4562 #4580
Merged
Fix #4562 #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
approved these changes
Oct 15, 2019
cescoffier
added
the
triage/waiting-for-ci
gsmet
force-pushed
the
features/ugly-fix-for-4562
branch
from
f667561
to
f1be19e
Compare
|
Just force pushed to fix the imports order. |
It's an ugly hack but after discussion it's a quick fix that will be revisited later. Explanation are in the code. Also add hot reload tests
cescoffier
force-pushed
the
features/ugly-fix-for-4562
branch
from
f1be19e
to
a662794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an ugly hack but after discussion it's a quick fix that will be revisited later.
Explanation are in the code.
Also add hot reload tests