Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure QuarkusJsonbComponentInstanceCreator can be used in unit tests #4658

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Ensure QuarkusJsonbComponentInstanceCreator can be used in unit tests #4658

merged 1 commit into from
Oct 18, 2019

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Oct 18, 2019

Fixes: #4090

@geoand geoand requested review from mkouba and gsmet October 18, 2019 11:16
@geoand geoand mentioned this pull request Oct 18, 2019
Closed
@geoand geoand added this to the 0.26.0 milestone Oct 18, 2019
gsmet
gsmet requested changes Oct 18, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for a very minor suggestion.

...sions/jsonb/runtime/src/main/java/io/quarkus/jsonb/QuarkusJsonbComponentInstanceCreator.java Outdated Show resolved Hide resolved
@geoand geoand requested a review from gsmet October 18, 2019 11:22
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 18, 2019
@geoand
Copy link
Contributor Author

geoand commented Oct 18, 2019

CI failure is known and unrelated to the PR.

@geoand geoand merged commit 8334796 into quarkusio:master Oct 18, 2019
@geoand geoand deleted the #4090 branch October 18, 2019 12:19
@mkouba
Copy link
Contributor

mkouba commented Oct 18, 2019

I know it's too late but it looks good ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@mkouba mkouba Awaiting requested review from mkouba

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.

Why Quarkus-JsonB is using ArC?
3 participants
@geoand @mkouba @gsmet