Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a NPE check for overridable description files #4902

Merged

Conversation

machi1990
Copy link
Member

This fix broken CI for current master: 69ade9d

/cc @maxandersen @aloubyansky @geoand

This fix broken CI for current master: 69ade9d
@machi1990 machi1990 added the area/platform Issues related to definition and interaction with Quarkus Platform label Oct 27, 2019
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand merged commit fccd696 into quarkusio:master Oct 27, 2019
@machi1990 machi1990 deleted the fix/npe-platform-desc-json-plugin branch October 27, 2019 12:10
@maxandersen
Copy link
Member

gah - don't know how I missed that. Thx both for fixing it!

@gsmet gsmet added this to the 0.27.0 milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants