-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Permissions Refactor #4956
Conversation
ba5a999
to
583933a
Compare
It may take a while for quarkus-http to hit central |
There is also a conflict now |
583933a
to
964eff6
Compare
* Blocking identity providers should used this context object to run blocking tasks, to prevent excessive and | ||
* unnecessary delegation to thread pools | ||
*/ | ||
interface AuthorizationRequestContext { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartwdouglas Can AuthorizationRequestContext
be optionally injected when needed into HttpSecurityPolicy
implementations ? May be HttpAuthorizer
's CONTEXT
can be CDI-produced ? So that the non-blocking implementations won't see it in the signature.
Or may be simpler, just renamed to something like BlockingAuthorizationRequestContext
?
But please ignore it if you plan to expand AuthorizationRequestContext
with more operations, not necessarily related to the blocking checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may end up eventually containing more contextual information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
quarkus-http Beta3 has hit Central. I rebased this one to be sure we don't have the doc issue, let's see what CI has to say. |
Closing. Will be part of a larger PR. |
No description provided.