Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Permissions Refactor #4956

Closed
wants to merge 3 commits into from

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@stuartwdouglas
Copy link
Member Author

It may take a while for quarkus-http to hit central

@geoand
Copy link
Contributor

geoand commented Oct 29, 2019

There is also a conflict now

@geoand geoand added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Oct 29, 2019
@stuartwdouglas stuartwdouglas removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Oct 29, 2019
* Blocking identity providers should used this context object to run blocking tasks, to prevent excessive and
* unnecessary delegation to thread pools
*/
interface AuthorizationRequestContext {
Copy link
Member

@sberyozkin sberyozkin Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartwdouglas Can AuthorizationRequestContext be optionally injected when needed into HttpSecurityPolicy implementations ? May be HttpAuthorizer's CONTEXT can be CDI-produced ? So that the non-blocking implementations won't see it in the signature.
Or may be simpler, just renamed to something like BlockingAuthorizationRequestContext ?
But please ignore it if you plan to expand AuthorizationRequestContext with more operations, not necessarily related to the blocking checks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may end up eventually containing more contextual information

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@gsmet
Copy link
Member

gsmet commented Oct 29, 2019

quarkus-http Beta3 has hit Central.

I rebased this one to be sure we don't have the doc issue, let's see what CI has to say.

@gsmet gsmet added this to the 0.27.0 milestone Oct 29, 2019
@gsmet
Copy link
Member

gsmet commented Oct 29, 2019

Closing. Will be part of a larger PR.

@gsmet gsmet closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants