Cleanup platformBomXXX and templates #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * maven and gradle uses various different spelling and casing of quarkusPlatformBomXXX This change addreses the need by: * search and replace to consistently use `quarkusPlatformXXX` (i.e not bom) references as the data is intended to be used to resolve the "platform" rather than a specific resource. * Future improvements can be done in pom.xml and gradle build files to allow overrides but changing that this close to release I evaluated as being a bad idea :)
|
lets wait for the CI build to confirm as it could break stuff if I missed a space ;) |
|
Too bad my review is worthless for CI, let's wait until someone with privileges to approve @geoand ? |
maxandersen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
quarkusPlatformBomXXX
This change addreses the need by:
quarkusPlatformXXX(i.e not bom)references as the data is intended to be used to resolve the "platform"
rather than a specific resource.
allow overrides but changing that this close to release I evaluated as
being a bad idea :)