Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to the latest dekorate version #7944

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Bump to the latest dekorate version #7944

merged 1 commit into from
Mar 18, 2020

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Mar 18, 2020

This pull request updates to the latest dekorate version, that:

  • Fixes the issue with long file names in S2i builds.
  • Uses Knative v1.

@boring-cyborg boring-cyborg bot added area/dependencies Pull requests that update a dependency file area/kubernetes labels Mar 18, 2020
@iocanel iocanel requested a review from geoand March 18, 2020 20:19
@geoand
Copy link
Contributor

geoand commented Mar 18, 2020

@michalszynkiewicz this needs to go in the 1.3.x line since it fixes an issue that @rsvoboda found while testing

@gastaldi gastaldi added this to the 1.4.0 milestone Mar 18, 2020
rsvoboda
rsvoboda approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an explicit dependency to dekorate 0.11.3 in my app and I'm able to proceed (not hitting that 100 characters limit for long file names)

I was able to deploy and run the app.

@machi1990 machi1990 merged commit a0fd85a into quarkusio:master Mar 18, 2020
@lordofthejars
Copy link
Contributor

@iocanel Does this mean that y issue about Knative configuration has been fixed or this is just the first step.

@iocanel
Copy link
Contributor Author

iocanel commented Mar 19, 2020

@iocanel Does this mean that y issue about Knative configuration has been fixed or this is just the first step.

It's just the first step.

@geoand geoand mentioned this pull request Mar 20, 2020
Closed
@geoand geoand linked an issue Mar 20, 2020 that may be closed by this pull request
s2i binary build - tar filename too long #8003
Closed
@gsmet gsmet changed the title chore: bump to the latest dekorate version. Bump to the latest dekorate version Mar 21, 2020
@gsmet gsmet modified the milestones: 1.4.0, 1.3.1.Final Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/kubernetes
Projects
None yet
Milestone
1.3.1.Final
Development

Successfully merging this pull request may close these issues.

s2i binary build - tar filename too long
7 participants
@iocanel @geoand @lordofthejars @rsvoboda @gastaldi @gsmet @machi1990