Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the definition of the page filename #2095

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

marcelstoer
Copy link
Contributor

@marcelstoer marcelstoer commented Aug 23, 2024

The original implementation did not consider that page.path has a different pattern for the "Main - SNAPSHOT" version. This currently leads to HTTP 404 links in such cases.

@marcelstoer
Copy link
Contributor Author

@gastaldi FYI

Copy link

github-actions bot commented Aug 23, 2024

🙈 The PR is closed and the preview is expired.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking the time to create a fix!

@gsmet gsmet merged commit e2d6356 into quarkusio:main Aug 23, 2024
1 check passed
@marcelstoer marcelstoer deleted the fix/page-filename branch August 23, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants