Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup & nitpicks on some of the code #2109

Closed

Conversation

nkolatsis
Copy link

No major changes. Just a few cleanups and nitpicks on the security-jwt guide.

Line 87
Unnecessary import removed

Line 108
Circle brackets typo removed

Line 197, 210
RequestScoped import and annotation removed - unnecessary for this stage of the guide

Line 125, 175, 241, 458, 545, 571
String concatenation typo removed

@gsmet
Copy link
Member

gsmet commented Sep 3, 2024

Thanks!

Changes look good but they need to be applied here: https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/security-jwt.adoc as this file will be rewritten when we release.

(There's a header in the file saying this but it's easy to miss if you jumped right to the issues you noticed!)

Will close this PR but please create one against the main repo (ideally mention in the commit and PR title that you are fixing doc issues in security-jwt.adoc).

@gsmet gsmet closed this Sep 3, 2024
@nkolatsis
Copy link
Author

Thanks for the feedback @gsmet

I've followed your advice and submitted a pull request on the correct repo now: quarkusio/quarkus#43207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants