Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding handling for W5500 socket disconnection #147

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Conversation

ryan-summers
Copy link
Member

This PR fixes #146 by updating Booster to handle and ignore NotReady indications, which are provided by the W5500 NAL whenever send() or recv() is called on a socket that is no longer connected. This rectifies a race condition in Minimq. Additionally, Minimq was updated to a version that does not contain the mentioned unwrap.

Testing
I cycled the broker on and off repeatedly over ~10 times and did not observe booster reset.

@jordens jordens merged commit 4e9f2d8 into develop Feb 2, 2021
@jordens jordens deleted the rs/issue-146 branch February 2, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Booster may reset after shutting down MQTT broker
2 participants