External MAC refactor, Smoltcp Update #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
changed the title
ryan-summers
commented
May 11, 2023
jordens
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #218 by entirely eliminatin the external MAC code. This became possible in smoltcp 0.9 because of the refactor of the
Devicetrait which allows borrowing out ofselffor the lifetime of the TX/RX tokens.In general, it might be nice to move the
smoltcp::phy::Deviceimplementation into the respective crates, but if we maintain it here, we keep tight control of the smoltcp version to be used.This PR also removes the
net::sharedmodule in favor ofsmoltcp-nal's implementation