Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option: actually return PathAbsent #128

Merged
merged 2 commits into from
Dec 12, 2022
Merged

option: actually return PathAbsent #128

merged 2 commits into from
Dec 12, 2022

Conversation

jordens
Copy link
Member

@jordens jordens commented Dec 10, 2022

No description provided.

@jordens jordens mentioned this pull request Dec 10, 2022
Merged
1 task
@jordens jordens requested a review from ryan-summers December 10, 2022 13:57
ryan-summers
ryan-summers approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@ryan-summers ryan-summers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix :)

@ryan-summers ryan-summers merged commit 1ac0646 into main Dec 12, 2022
@ryan-summers ryan-summers deleted the rj/option-absent branch December 12, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-summers ryan-summers ryan-summers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordens @ryan-summers