Support heapless primitives #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about |
|
Recursive macros, sure.. ;) |
|
Note that the macro should not be needed at all. It could be a plain generic impl. The only reason the macro is needed is to exclude arrays from the generic impl (no negative trait bounds or negative impl yet). |
|
Maybe that's an indication that having the custom impl of array is a suboptimal solution. |
Correct. Is there a way we can exclude arrays in a generic manner from the blanket impl? I'm not so sure yet. |
jordens
reviewed
Oct 19, 2022
jordens
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to have heapless string support for miniconf out of the box.
I tested this working but you can probably fumble it into the macro as well? Sorry, I'm not an expert on macros and I didn't want to spend more time on this now. Maybe this is easy for you @ryan-summers? :)