Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for smoltcp 0.9 #41

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Adding support for smoltcp 0.9 #41

merged 2 commits into from
Mar 16, 2023

Conversation

ryan-summers
Copy link
Member

This PR fixes #40 by support smoltcp 0.9

In the future, we should implement DNS traits from embedded-nal as well

jordens
jordens reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
I would have thought the lifetime generics in the various stacks can go away now as well.

@ryan-summers
Copy link
Member Author

The lifetime generic just moved because SocketSet<'a> has the generic. Previously, SocketSet was owned by smoltcp::iface::Interface, however, now we moved it one level higher, but it's still owned by us. Hence, why we still have to carry around the lifetime for memory owned by the socket set

jordens
jordens approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/lib.rs Show resolved Hide resolved
@jordens jordens merged commit a9b6db6 into main Mar 16, 2023
@jordens jordens deleted the feature/smoltcp-0.9 branch March 16, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordens jordens jordens approved these changes

Assignees

@jordens jordens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

smoltcp 0.9
2 participants
@ryan-summers @jordens