-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTT logging, probe-run #358
Conversation
jordens
commented
May 13, 2021
- use rtt logging
- remove rtt feature
- update hitl script
- README: streamline docs a bit, add probe-run
- CHANGELOG: update
- README: document lockin, cleanup instructions, use probe-run
- set target-cpu=cortex-m7, MSRV 1.52.0, use probe-run
bors try |
1 similar comment
bors try |
bors try Bors doesn't look very cooperative today. HITL results are at https://github.com/quartiq/stabilizer/runs/2574636512?check_suite_focus=true |
@@ -1,15 +1,10 @@ | |||
[target.'cfg(all(target_arch = "arm", target_os = "none"))'] | |||
runner = "gdb-multiarch -q -x openocd.gdb" | |||
runner = "probe-run --chip STM32H743ZITx --speed 30000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does probe-run spin up a GDB server as well? Or is this just a command to program the chip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I'd prefer if we kept around an easy way to spin up GDB, which was previously cargo run
. The command-line way to flash was previously just cargo embed --bin dual-iir
, and cargo run --bin dual-iir
was meant for interactive debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still two ways to flash and while still getting gdb access as before. Just the command to start gdb changes.
- Start
cargo embed
with options to provide the gdb stub (https://github.com/probe-rs/cargo-embed/blob/master/src/config/default.toml#L71) or startopenocd
as before. cargo build --release --bin app && gdb-multiarch -q -x openocd.gdb path/to/app
to build and start gdb.
You can still use cargo embed
to flash in the same way. That doesn't change. The command to start GDB becomes a bit longer.
The tooling for GDB+openocd is (a) significantly more complex to install (b) we don't test it, (c) doesn't provide usable logging, and (d) it isn't used as frequently compared to "just" flashing. Therefore I'd rather have a low entry barrier, streamlined runner that gives me backtraces and convenient logging for debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, probe-run gives a logging interface. That's no issue - I can get gdb set up locally or see if I can make a custom cargo profile or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A cargo profile might be nice for gdb.
* origin/master: remove unused dependencies remove unused dependencies
bors merge |
Build succeeded: |