Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerating doc CI tests #405

Merged
merged 10 commits into from
Jul 19, 2021
Merged

Accelerating doc CI tests #405

merged 10 commits into from
Jul 19, 2021

Conversation

ryan-summers
Copy link
Member

@ryan-summers ryan-summers commented Jul 19, 2021

This PR fixes #403 by utilize github actions caches to accelerate the doc test CI check. cargo-deadlinks is cached, ruby gems are cached, and Rust dependency installations are cached.

Questions:
Should the Rust cache be tagged on a specific key so that we don't pollute the cache with each PR?

@ryan-summers ryan-summers changed the title Rs/issue 403/jekyll acceleration Accelerating doc CI tests Jul 19, 2021
@ryan-summers ryan-summers marked this pull request as ready for review July 19, 2021 12:54
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

src/configuration.rs Outdated Show resolved Hide resolved
Co-authored-by: Robert Jördens <rj@quartiq.de>
@jordens
Copy link
Member

jordens commented Jul 19, 2021

bors r+

@ryan-summers
Copy link
Member Author

ryan-summers commented Jul 19, 2021

bors merge

Edit: I should scroll up before sending bors commands

@bors
Copy link
Contributor

bors bot commented Jul 19, 2021

Already running a review

@bors
Copy link
Contributor

bors bot commented Jul 19, 2021

Build succeeded:

@bors bors bot merged commit f29a663 into master Jul 19, 2021
@bors bors bot deleted the rs/issue-403/jekyll-acceleration branch July 19, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: TODO
2 participants