Updating miniconf/minimq to utilize pings #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While it looks like pings properly cause minimq to disconnect, it looks like minimq may not be able to establish a TCP socket aftwards. |
|
After fixing some issues with minimq's ping request/response timeouts, this now properly re-establishes an MQTT connection that is broken.
|
Closed
|
bors try |
tryBuild succeeded: |
|
bors try |
tryBuild succeeded: |
jordens
approved these changes
Oct 8, 2021
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
stabilizerto utilize miniconf/minimq versions that implement MQTT ping request/responses periodically.This fixes #433
TODO: