-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix embed
and verbatim
knitr's engine for revealjs
#4732
Conversation
…bed` handler Currently the `embed` handler is only for Jupyter. Discovered while looking at #4712 - revealjs does not work with knitr embed engine
because those engine expect echo, but revealjs default to FALSE
Following meeting and discussion with @cscheid this needs to be split as the Currently all are names(knitr::knit_engines$get())
Meaning So we need first another PR for the handler adaptation |
…to's `embed` handler" This reverts commit 53d8703.
Other language are shortcodes
This will avoid format defaulting to echo: false to hide those chunks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
General fix : With new
embed
feature in 1.3 for Jupyter, we need to make sure this does not overrideembed
Knitr engine (cc @dragonstyle as discussed)Specific to revealjs: Set echo = TRUE for
embed
andverbatim
engine whenrevealjs
because those engine expectecho
to be TRUE to be shown, butrevealjs
default toFALSE
This fix #4712
Note: our extension to include external file works fine - but it feels like those engines should still work correctly
By working on these R files, I think we can improve the handling of chunk hook, especially to treat those two engines as others (if we want to support
echo: fenced
for example. At first I did it in this PR, but then as this is some R refactoring more generic, I'll do it in another PR (#4735). We can then postpone to 1.4 if we think this is two much.