Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display warning if user doesn't have rights to change permissions #4474 #4804

Merged
merged 6 commits into from
Mar 14, 2023

Conversation

allenmanning
Copy link
Contributor

Display warning if user doesn't have rights to change permissions #4474

@@ -17,7 +17,7 @@ python_exists=$(command -v python)
if [ -z $python_exists ]
then
python_exists=$(command -v python3)
if [ -z python_exists]
if [ -z python_exists ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cderv Can you please review? This got my tests running without errors.

src/publish/confluence/confluence-verify.ts Outdated Show resolved Hide resolved
@allenmanning allenmanning added this to the v1.3 milestone Mar 13, 2023
@cderv cderv self-requested a review March 13, 2023 16:08
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is ok for this update on the sh script. If it works on your side with Mac, should be ok.

tests/configure-test-env.sh Outdated Show resolved Hide resolved
@allenmanning allenmanning self-assigned this Mar 14, 2023
@allenmanning allenmanning added the publishing-confluence Confluence publishing of documents and projects label Mar 14, 2023
@allenmanning allenmanning merged commit 94a815f into main Mar 14, 2023
@allenmanning allenmanning deleted the task/warn-perms branch March 14, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publishing-confluence Confluence publishing of documents and projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants