improve error message when attempting to run a JSON filter #6211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: a Lua filter from an extension doesn't have a file extension. We call it like this:
This makes sense because the user doesn't know the internal name of the Lua file in the filter. However, this notation is ambiguous. If the extension doesn't exist (or, as commonly happens, is misspelled), we interpret the filter as a JSON filter. In this case, our current error message is not very helpful.
This PR improves the situation.
Example: