-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forward code-summary to ojs cells #7804
Conversation
@cderv sorry to tag you here, but I'm pretty confused about why my test passes locally but fails here. Could this have something to do with the recent ojs code cell changes that just happened on knitr? |
Yes exactly. @yihui did the change in dev version and we are testing against it. You can also install it locally. When you update configuration for test, it should do it by the way quarto-cli/tests/configure-test-env.sh Lines 10 to 14 in f9ed454
#7799 is the solution here. We were missing the command for knitr to account for the content, but by adding them, we need to correctly account for the fact that now knitr is parsing the YAML part, and it needs to be added back. It wasn't before my PR quarto-cli/src/resources/rmd/execute.R Lines 55 to 62 in f9ed454
Before quarto-cli/src/resources/rmd/execute.R Lines 55 to 61 in 2ed010e
See So dev knitr is not working / compatible with Quarto 1.3 - only with current main as I merged #7799 If you rebase, the test should pass. |
Hm.. I did merge against main before testing this, though! |
I merged today - not yesterday. When CI ran for this PR, the change of #7799 were not in main. You should try rebase on main and see - I think this will pass. |
Closes #4927