Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add articles to navbar #149

Open
eitsupi opened this issue Feb 1, 2024 · 3 comments · Fixed by r-lib/pkgdown#2404
Open

Add articles to navbar #149

eitsupi opened this issue Feb 1, 2024 · 3 comments · Fixed by r-lib/pkgdown#2404
Labels
enhancement New feature or request

Comments

@eitsupi
Copy link

eitsupi commented Feb 1, 2024

The changelog and article listings do not appear to be displayed in the navbar.

@cderv
Copy link
Collaborator

cderv commented Feb 1, 2024

Oh, thanks. Indeed, the changelog is missing. There was none, and when I added one I did not update the website. I'll do that.

For article, there is none because Publishing one was made on its own navbar item, and new vignettes are Quarto based, and pkgdown does not support this.

So I need to think more on how to do that.

  • Either duplicate vignette example as an article for the website not using quarto
  • Either not using specific quarto feature in the .qmd vignette.

Thanks for the report!

cderv added a commit that referenced this issue Feb 1, 2024
thanks @eitsupi - reported in #149
@cderv cderv changed the title pkgdown website's nav bar Add articles to navbar Feb 1, 2024
@cderv cderv added the enhancement New feature or request label Feb 1, 2024
@cderv
Copy link
Collaborator

cderv commented Feb 1, 2024

I have added the news and renamed this issue about the vignettes as article

@rcannood
Copy link

rcannood commented Feb 23, 2024

I managed to get this to work by changing a regex from [Rr]md to [Rrq]md in {pkgdown}. Proof of the pudding is here: https://funkyheatmap.github.io/funkyheatmap.

I created a PR at r-lib/pkgdown#2404 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants