Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSGi: Make HikariCP and c3p0 Import Optional #565

Closed
swimmesberger opened this issue Mar 11, 2020 · 1 comment
Closed

OSGi: Make HikariCP and c3p0 Import Optional #565

swimmesberger opened this issue Mar 11, 2020 · 1 comment
Labels
stale Inactive items that will be automatically closed if not resurrected

Comments

@swimmesberger
Copy link

swimmesberger commented Mar 11, 2020

As discussed here: #306 - the HikariCP/c3p0 dependency is optional (provided scope) so the OSGi Import-Package should also be made optional.

For OSGi the c3p0 dependency can be made optional without backward compatibility issues because in most OSGi environments transitive dependency are only resolved but not downloaded automatically.

As seen here:

javax.servlet;resolution:=optional,

It's probably just necessary to add:

com.mchange.v2.c3p0;resolution:=optional
com.zaxxer.hikari;resolution:=optional
travishaagen added a commit to travishaagen/quartz that referenced this issue Jul 15, 2020
@stale
Copy link

stale bot commented Aug 2, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Inactive items that will be automatically closed if not resurrected label Aug 2, 2021
jhouserizer added a commit that referenced this issue Aug 4, 2021
Make HikariCP and c3p0 OSGi imports optional (Fixes #565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Inactive items that will be automatically closed if not resurrected
Projects
None yet
Development

No branches or pull requests

1 participant