Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve Cypress select override #369

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

n05la3
Copy link
Contributor

@n05la3 n05la3 commented Mar 19, 2024

Fixes #343

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • New test runner
  • Documentation
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

If you are adding a new test runner, have you...? (check all)

  • Created an issue first?
  • Registered it in /packages/base/runners.json?
  • Added it to /README.md?
  • Included one test that runs baseline.spec.vue?
  • Added and updated documentation?
  • Included a recipe folder with properly building quasar project?

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on Windows
  • It's been tested on Linux
  • It's been tested on MacOS
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@Jackson3195
Copy link

Jackson3195 commented Apr 3, 2024

Any ideas when this might be released? Or how to get this fix; in the mean time?

@Jackson3195
Copy link

@n05la3 or @IlCallo - Apologies for the tag, but was wondering if anyone had an ETA on when this might head into production?

Reason I ask is because without this, we can't seem to run cypress in our CI/CD pipeline.

Thank you, in advance!

@IlCallo
Copy link
Member

IlCallo commented Jun 20, 2024

This has been released in version 6.1.0 back in April
Whatever is breaking your CI/CD pipeline isn't related to this feature, or you haven't updated your deps to the latest available release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple select component randomly fails test
3 participants