Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action sheet bug #1007

Closed
mesqueeb opened this issue Oct 16, 2017 · 4 comments
Closed

Action sheet bug #1007

mesqueeb opened this issue Oct 16, 2017 · 4 comments
Milestone

Comments

@mesqueeb
Copy link
Contributor

Software version

Quasar CLI v0.6.4
App running on Quasar v0.14.5
Browsers: Chrome

What did you get as the error?

vue.runtime.esm.js?ff9b:3034 Uncaught TypeError: Cannot read property 'active' of undefined
at VueComponent.opened (quasar.esm.js?8bfb:12482)
at Watcher.get (vue.runtime.esm.js?ff9b:3029)
at Watcher.evaluate (vue.runtime.esm.js?ff9b:3136)
at VueComponent.computedGetter [as opened] (vue.runtime.esm.js?ff9b:3421)
at VueComponent.close (quasar.esm.js?8bfb:12492)
at Proxy.boundFn (vue.runtime.esm.js?ff9b:186)
at click (quasar.esm.js?8bfb:12457)
at invoker (vue.runtime.esm.js?ff9b:1933)
at HTMLDivElement.fn._withTask.fn._withTask (vue.runtime.esm.js?ff9b:1768)

What steps did you take, to get the error?

Open the Action sheet once. Choose an option.
Open it a second time. and it bugs.

Here's my action sheet:

chooseLanguageMobile()
{
	ActionSheet.create({
		title: this.get.text.settings.language,
		actions: [
			{
				label: 'English',
				handler: () => { store.dispatch('setLanguage', 'en') }
			},
			{
				label: '日本語',
				handler: () => { store.dispatch('setLanguage', 'ja') }
			},
		],
		dismiss: { // label is used only for iOS theme
			label: 'Cancel',
			handler: () => {  }
		}
	})
},
@mesqueeb
Copy link
Contributor Author

The error seems to be pointing here:

  computed: {
    opened: function opened () {
      return this.$refs.dialog.active
    },
    contentCss: function contentCss () {
      if (this.$q.theme === 'ios') {
        return {backgroundColor: 'transparent'}
      }
    }

rstoenescu added a commit that referenced this issue Oct 17, 2017
rstoenescu added a commit that referenced this issue Oct 17, 2017
@rstoenescu rstoenescu added this to the v0.14.6 milestone Oct 17, 2017
@rstoenescu
Copy link
Member

Available in v0.14.6 (just released it).

@mesqueeb
Copy link
Contributor Author

Thank you so much!
I tried today debugging through the framework but couldn’t find it. Will be interested to see what has changed.

@pure-zero
Copy link
Contributor

pure-zero commented Oct 25, 2017

This issue is also occurring for me on 0.13.10, are there any workarounds I can use, without having to update?

pure-zero pushed a commit to pure-zero/quasar that referenced this issue Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants