Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Alert ignoring initial v-model value. #1019

Closed
SeregPie opened this issue Oct 19, 2017 · 1 comment
Closed

[Bug] Alert ignoring initial v-model value. #1019

SeregPie opened this issue Oct 19, 2017 · 1 comment
Milestone

Comments

@SeregPie
Copy link
Contributor

SeregPie commented Oct 19, 2017

Hello.

Just a small bug, but it is annoying. Alert, Modal etc. are visible/invisible per default at the beginning, ignoring initial value of v-model and changes their visibility only on the next value change.

There should be default value for value.

value: {type: Boolean, default: true} // alert
value: {type: Boolean, default: false} // modal

And then there are 2 ways to fix it.

  1. QAlert.vue#L86: init active in data function
data() {
  return {active: this.value};
}
  1. QAlert.vue#L90: immediate value watcher
value: {
  handler(v) { ... },
  immediate: true,
}
@rstoenescu rstoenescu changed the title [Bug] Alert, Modal etc. ignoring initial v-model value. [Bug] Alert ignoring initial v-model value. Oct 20, 2017
@rstoenescu rstoenescu added this to the v0.14.7 milestone Oct 20, 2017
@rstoenescu
Copy link
Member

Can't see this issue with Modal.

Fix for Alert available in edge and future v0.14.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants