Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Negative" toast icon change from "whatshot" to "error" #168

Closed
laurentpayot opened this issue Nov 7, 2016 · 3 comments
Closed

"Negative" toast icon change from "whatshot" to "error" #168

laurentpayot opened this issue Nov 7, 2016 · 3 comments
Milestone

Comments

@laurentpayot
Copy link
Contributor

laurentpayot commented Nov 7, 2016

I was surprised to see that the negative type toast displays the social icon whatshot, and that I can't change it. To display error toasts with the material design icon error I have to create toasts with all the options.

Wouldn't an error type toast (with the material design icon error) be useful along with info and warning?

@laurentpayot laurentpayot changed the title 'error' type toast? "Negative" toast icon change from "whatshot" to "error" Nov 7, 2016
@laurentpayot laurentpayot added this to the v0.9 milestone Nov 7, 2016
@rstoenescu
Copy link
Member

You already have "info" and "warning" Toast types. Please check documentation.
On the icon I felt it was more appropriate to use "whatshot" instead of "error". "error" icon seems milder than the warning. Anyways, pushed patch for the "negative" Toast to use "error" instead of "whatshot".

@rstoenescu
Copy link
Member

If there is a solid reason for further changes (let's say like the icon chosen for "negative" Toasts) we can tweak the other "default" types like "info", "warning" and "positive" too.

@laurentpayot
Copy link
Contributor Author

laurentpayot commented Nov 7, 2016

I knew we already have "info" and "warning" Toast types. My only concern was the icon. If "negative" toasts now have the real "error" icon then I'm happy 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants